Two rename anchors nothing checks: the :global mark tints, and the vocabularies vs their migration CHECKs #186
Labels
No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
lz/agent-nexus#186
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Found by the review agents on #180, and deliberately left out of it to keep that diff to the duplication it was about. Both are the same shape — a place a vocabulary is written down that no compiler and no test reaches — and one issue because a single test pass would close both.
1. Two
:globalmark tints outsideapp.css#180 closes the
app.csshalf:attention.test.tsnow checks both directions, everySESSION_MARKhas a rule that paints, and a stale.status-dot.<mark>for a mark that no longer exists fails. Two component stylesheets style a mark name and are reached by neither:nexus/src/lib/components/SessionRow.svelte:143—.shell-row :global(.shell-icon.needs-you) { color: var(--warn); }, fed byclass={'shell-icon ' + dotClass}at:66nexus/src/lib/components/main-page/WorkspaceRail.svelte:313—.seg :global(.needs-you) { color: var(--warn); }, fed byshellMark()at:56Rename
needs-youand both tints go dead with every gate green. The other hardcoded'needs-you'literals (WorkspaceRail.svelte:56,workspaces.svelte.ts:466,RailHoverCard.svelte:168) are comparisons againstSessionMark-typed values, so the compiler already catches those — these two are strings inside a<style>block, which it never sees.Scanning component
<style>blocks needs care in one direction only: a mark that appears in NO component is normal, so only the reverse check applies — a:global(...)rule naming something that is not aSESSION_MARK.2. Nothing pins a vocabulary against the migration
CHECKthat backs itEvery vocabulary #180 collapsed has a database constraint behind it, which is the real backstop against a silent widening:
SESSION_KINDSmigrations/0006_workspace_shell_session.ts:8—kind in ('session','workspace_shell')PREVIEW_SCHEMESmigrations/0008_previews_scheme.ts:8—scheme in ('http','https')PROVIDER_KINDSmigrations/0001_init.ts:15—kind in ('forgejo','github')Adding a member to any array now compiles, ships, reaches the wire, and fails at the INSERT. That is loud, but it is loud at runtime on the operator's instance rather than at the gate. A parity test shaped like
bind-host.test.ts— read the migration source, assert the array and the constraint name the same set — turns it into a red test.Worth stating so nobody "fixes" it the other way: the constraint is not redundant with the array, and neither should be deleted. The array is what the TypeScript and the request schemas read; the constraint is what the database enforces on rows written before or outside them.
Not in scope
WORKER_STATUSEShas no constraint to pin against —workers.statusistextwith none (migration 0001), which AGENTS.md already notes.SESSION_STATUSESdoes have one, so it can join the same test.