dockview warns that `dockview-core` is an internal package #60

New issue

Closed

opened 2026-07-12 12:31:23 +02:00 by lz · 0 comments

lz commented

2026-07-12 12:31:23 +02:00

Owner

Symptom

With the dock from #58, the browser console logs once on load:

dockview: do not use "dockview-core" directly — it is an internal package.
Use the "dockview" package, the JavaScript version of dockview, instead.
This notice is shown once.

Everything works. This is a warning, not an error, and there are no other console errors.

Context

PR #58 depends on dockview-core@7.0.2 directly. That choice was deliberate at the time: dockview-core is the framework-agnostic core, it has zero runtime dependencies, and we hand-rolled the Svelte binding (nexus/src/lib/dock/svelte-renderer.svelte.ts, ~50 lines) because dockview ships no official Svelte adapter.

The warning suggests upstream now considers dockview (not dockview-core) the supported vanilla-JS entry point. Historically dockview was the React wrapper, so this appears to be a change in how the packages are positioned.

What to check

Does dockview (the package) actually expose a framework-agnostic API, or does it pull in React? Check its dependencies and its createDockview export. Probe the published tarball, not the docs — the docs site 404s on several pages, and PR #58 already found one type (GroupPanelViewState) that the docs imply is exported from the root but isn't.
If dockview is dependency-free and exports the same createDockview / IContentRenderer surface, this is likely a one-line import swap in Dock.svelte plus the type imports in svelte-renderer.svelte.ts and layout.ts.
If it drags in React, stay on dockview-core and suppress or simply accept the warning — a React dependency is not worth silencing a once-per-load console notice.

Priority

Low. Cosmetic today. Worth resolving before it becomes a real deprecation, and worth knowing which package we should be on before PR-B/PR-C build more on this foundation.

## Symptom With the dock from #58, the browser console logs once on load: ``` dockview: do not use "dockview-core" directly — it is an internal package. Use the "dockview" package, the JavaScript version of dockview, instead. This notice is shown once. ``` Everything works. This is a warning, not an error, and there are no other console errors. ## Context PR #58 depends on `dockview-core@7.0.2` directly. That choice was deliberate at the time: `dockview-core` is the framework-agnostic core, it has **zero runtime dependencies**, and we hand-rolled the Svelte binding (`nexus/src/lib/dock/svelte-renderer.svelte.ts`, ~50 lines) because dockview ships no official Svelte adapter. The warning suggests upstream now considers `dockview` (not `dockview-core`) the supported vanilla-JS entry point. Historically `dockview` was the React wrapper, so this appears to be a change in how the packages are positioned. ## What to check 1. Does `dockview` (the package) actually expose a framework-agnostic API, or does it pull in React? Check its `dependencies` and its `createDockview` export. **Probe the published tarball, not the docs** — the docs site 404s on several pages, and PR #58 already found one type (`GroupPanelViewState`) that the docs imply is exported from the root but isn't. 2. If `dockview` is dependency-free and exports the same `createDockview` / `IContentRenderer` surface, this is likely a one-line import swap in `Dock.svelte` plus the type imports in `svelte-renderer.svelte.ts` and `layout.ts`. 3. If it drags in React, **stay on `dockview-core`** and suppress or simply accept the warning — a React dependency is not worth silencing a once-per-load console notice. ## Priority Low. Cosmetic today. Worth resolving before it becomes a real deprecation, and worth knowing which package we should be on before PR-B/PR-C build more on this foundation.

lz referenced this issue from a commit

2026-07-13 11:07:09 +02:00

fix(dock): use the dockview package, not dockview-core (closes #60)

lz referenced this issue from a pull request that will close it,

2026-07-13 11:08:03 +02:00

fix(dock): use the dockview package, not dockview-core (closes #60) #64

lz closed this issue

2026-07-13 21:11:42 +02:00

lz referenced this issue from a commit

2026-07-13 21:11:42 +02:00

Merge pull request 'fix(dock): use the dockview package, not dockview-core (closes #60)' (#64) from fix/dockview-package into main