lz/agent-nexus
lz/agent-nexus
1
0
Fork 0
Code Issues 10 Pull requests 4 Projects Releases Packages 2 Wiki Activity Actions

fix(artifacts): collapsible comment drawer in the fullscreen pop-out #46

Open
lz wants to merge 1 commit from fix/comment-collapse into main
pull from: fix/comment-collapse
merge into: lz:main
Conversation 0 Commits 1 Files changed 1 +31
lz commented 2026-06-27 00:46:22 +02:00
Owner
Copy link

Problem

Comments are collapsible on artifacts in the in-app artifacts tab (the sidebar slides into a right drawer on mobile, toggled from the toolbar). But the fullscreen pop-out view of an artifact never opted into that behavior — so on mobile the comment column was stuck and couldn't be collapsed.

Fix

The drawer machinery already lives entirely in ArtifactViewer + CommentSidebar (the mobileDrawer prop, the bindable commentsOpen, the scrim overlay, and the ≤768px slide-in animation). The pop-out page simply wasn't passing those props.

This wires them through and adds a mobile-only comments toggle button in the pop-out header (with a live comment count), mirroring how MainSplit drives the in-app tab.

  • No changes to ArtifactViewer or CommentSidebar — behavior is fully reused.
  • Desktop is unchanged: the sidebar stays a fixed column and the toggle is hidden.
  • One file changed (+page.svelte for the pop-out route).

Verification

  • pnpm install + pnpm run typecheck → 0 errors across 915 files.

https://claude.ai/code/session_015zV3LB6tz8yvZTZ92kQzeF

## Problem Comments are collapsible on artifacts in the in-app artifacts tab (the sidebar slides into a right drawer on mobile, toggled from the toolbar). But the **fullscreen pop-out** view of an artifact never opted into that behavior — so on mobile the comment column was stuck and couldn't be collapsed. ## Fix The drawer machinery already lives entirely in `ArtifactViewer` + `CommentSidebar` (the `mobileDrawer` prop, the bindable `commentsOpen`, the scrim overlay, and the `≤768px` slide-in animation). The pop-out page simply wasn't passing those props. This wires them through and adds a mobile-only `comments` toggle button in the pop-out header (with a live comment count), mirroring how `MainSplit` drives the in-app tab. - **No changes** to `ArtifactViewer` or `CommentSidebar` — behavior is fully reused. - Desktop is unchanged: the sidebar stays a fixed column and the toggle is hidden. - One file changed (`+page.svelte` for the pop-out route). ## Verification - `pnpm install` + `pnpm run typecheck` → 0 errors across 915 files. https://claude.ai/code/session_015zV3LB6tz8yvZTZ92kQzeF
fix(artifacts): collapsible comment drawer in the fullscreen pop-out
All checks were successful
ci / nexus (pull_request) Successful in 3m19s
Details
ci / images (./nexus, agent-nexus) (pull_request) Successful in 4m29s
Details
ci / images (./worker, agent-nexus-worker, base) (pull_request) Successful in 52s
Details
ci / images (PLAYWRIGHT_CLI_VERSION=0.1.13, ./worker, agent-nexus-worker, -playwright0.1.13, playwright) (pull_request) Successful in 1m12s
Details
aa5484bfd3 
The in-app artifacts tab already collapses the comment sidebar into a
right drawer on mobile, but the fullscreen pop-out page never opted into
it — so on mobile the comments column was stuck, not collapsible.

Wire the existing ArtifactViewer machinery (`mobileDrawer` + bindable
`commentsOpen`) into the pop-out and add a mobile-only header toggle,
mirroring MainSplit's in-app pattern. No changes to ArtifactViewer or
CommentSidebar — the drawer, scrim, and slide-in animation are reused.

Claude-Session: https://claude.ai/code/session_015zV3LB6tz8yvZTZ92kQzeF
All checks were successful
ci / nexus (pull_request) Successful in 3m19s
Details
ci / images (./worker, agent-nexus-worker, base) (pull_request) Successful in 52s
Details
ci / images (PLAYWRIGHT_CLI_VERSION=0.1.13, ./worker, agent-nexus-worker, -playwright0.1.13, playwright) (pull_request) Successful in 1m12s
Details
ci / images (./nexus, agent-nexus) (pull_request) Successful in 4m29s
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/comment-collapse:fix/comment-collapse
git switch fix/comment-collapse

Merge

Merge the changes and update on Forgejo.
git switch main
git merge --no-ff fix/comment-collapse
git switch fix/comment-collapse
git rebase main
git switch main
git merge --ff-only fix/comment-collapse
git switch fix/comment-collapse
git rebase main
git switch main
git merge --no-ff fix/comment-collapse
git switch main
git merge --squash fix/comment-collapse
git switch main
git merge --ff-only fix/comment-collapse
git switch main
git merge fix/comment-collapse
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lz/agent-nexus!46
No description provided.